New Adapter: Adverxo #4018

dev-adverxo · 2024-10-28T15:29:19Z

Summary

This PR introduces the Adverxo bidder adapter for Prebid Server. It supports the following mediatypes:

Banner
Video
Native

Maintainer Contact: [email protected]

github-actions · 2024-10-28T15:30:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, fb3750c

adverxo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:40:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:86:	MakeBids		95.7%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:134:	getAdUnitsParams	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:153:	modifyImp		100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:170:	makeRequestCopyWithImp	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:177:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:186:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:201:	getNativeAdm		90.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:221:	resolveMacros		100.0%
total:									(statements)		93.1%

static/bidder-info/adverxo.yaml

github-actions · 2024-11-04T12:11:20Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 913ea87

adverxo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:40:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:86:	MakeBids		95.7%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:134:	getAdUnitsParams	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:153:	modifyImp		100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:170:	makeRequestCopyWithImp	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:177:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:186:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:201:	getNativeAdm		90.0%
github.com/prebid/prebid-server/v2/adapters/adverxo/adverxo.go:221:	resolveMacros		100.0%
total:									(statements)		93.1%

bsardo · 2024-11-04T17:53:31Z

Hi @dev-adverxo, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

github-actions · 2024-11-05T08:17:23Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 07b8d6b

adverxo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:40:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:86:	MakeBids		95.7%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:134:	getAdUnitsParams	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:153:	modifyImp		100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:170:	makeRequestCopyWithImp	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:177:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:186:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:201:	getNativeAdm		90.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:221:	resolveMacros		100.0%
total:									(statements)		93.1%

dev-adverxo · 2024-11-05T08:25:59Z

Hi @dev-adverxo, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:
import (
    "github.com/prebid/prebid-server/v3/adapters"
)
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

Hi @bsardo, thanks for the update. We've made the necessary changes and ensured that the tests passed.

Let us know if there's anything else.

bretg

host cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config.

For PBS, it's host should be specified in your YAML file. If you wish to have an optional impression-level host override, that's ok.

dev-adverxo · 2024-11-07T17:42:00Z

host cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config.

For PBS, it's host should be specified in your YAML file. If you wish to have an optional impression-level host override, that's ok.

Hi @bretg, just to clarify, we don’t have a host parameter here. It’s only present in Prebid.js.

github-actions · 2024-11-08T13:45:46Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4fc858b

adverxo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:40:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:86:	MakeBids		95.7%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:134:	getAdUnitsParams	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:153:	modifyImp		100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:170:	makeRequestCopyWithImp	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:177:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:186:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:201:	getNativeAdm		90.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:221:	resolveMacros		100.0%
total:									(statements)		93.1%

dev-adverxo · 2024-11-08T14:20:50Z

Hi @przemkaczmarek sorry for the changes after your review, but in the review process of our Prebid.js adapter we decide to introduce two aliases of our adapter.

github-actions · 2024-11-11T09:42:12Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7b84702

adverxo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:40:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:86:	MakeBids		95.7%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:134:	getAdUnitsParams	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:153:	modifyImp		100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:170:	makeRequestCopyWithImp	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:177:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:186:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:201:	getNativeAdm		90.0%
github.com/prebid/prebid-server/v3/adapters/adverxo/adverxo.go:221:	resolveMacros		100.0%
total:									(statements)		93.1%

dev-adverxo · 2024-11-18T08:43:01Z

Hi @bretg, sorry for tagging you again. I noticed the "required changes" tag is still present here, but it seems to be related to the optional host parameter, which we have already resolved. Could you please mark it as solved? Thanks!

bretg · 2024-11-18T14:13:34Z

@przemkaczmarek and @bsardo , please review when you get a chance.

przemkaczmarek · 2024-12-12T12:46:13Z

static/bidder-info/adport.yaml

@@ -0,0 +1,9 @@
+endpoint: "https://adport.pbsadverxo.com/auction?id={{.AdUnit}}&auth={{.TokenID}}"


przemkaczmarek · 2024-12-12T12:46:31Z

static/bidder-info/adverxo.yaml

@@ -0,0 +1,22 @@
+endpoint: "https://pbsadverxo.com/auction?id={{.AdUnit}}&auth={{.TokenID}}"


static/bidder-info/adverxo.yaml

przemkaczmarek · 2024-12-12T14:43:51Z

adapters/adverxo/params_test.go

+	`null`,
+	`{}`,
+	`{"adCode": "string", "seatCode": 5, "originalPublisherid": "string"}`,
+	`{ "adUnitId": 5}`,


add test with only "auth"

Hi @przemkaczmarek, we already had a test for only "auth", it is on line 47, if it is not what you mean or need something else, please, let us know, thanks!

dev-adverxo · 2025-01-07T12:09:39Z

@bsardo @bretg @przemkaczmarek Hi, If there's anything else we can do from our side to facilitate the review process or address any concerns, please don't hesitate to let us know.

VeronikaSolovei9 · 2025-01-11T01:34:45Z

New adapters must also open a PR against the Prebid Docs repository here: https://github.com/prebid/prebid.github.io/

Please see the User Documentation section of the new adapter developer guide.

dev-adverxo · 2025-01-13T08:21:42Z

New adapters must also open a PR against the Prebid Docs repository here: https://github.com/prebid/prebid.github.io/

Please see the User Documentation section of the new adapter developer guide.

Hello @VeronikaSolovei9, we already had a JavaScript adapter; however, I’ve submitted a pull request with pbs set to true. Thanks for your feedback!:

prebid/prebid.github.io#5807

VeronikaSolovei9

Thank you, I overlooked the documentation exists already. Approved.

dev-adverxo · 2025-01-14T08:57:37Z

Hi @VeronikaSolovei9, What is missing to merge the adapter? Is there anything else we can do to help? Regarding the 'Changes Requested' tag that is still present here, it was something that never affected this adapter—it only impacted the JavaScript plugin. I mentioned this to Bretg, and he asked your teammates to double-check, but I see that no one has removed the 'Changes Requested' tag yet. You can read the entire pull-request conversation to understand. Thanks!

Init adverxo adapter

fb3750c

dev-adverxo mentioned this pull request Oct 28, 2024

New bid adapter: Adverxo prebid/prebid.github.io#5676

Merged

8 tasks

przemkaczmarek reviewed Oct 29, 2024

View reviewed changes

static/bidder-info/adverxo.yaml Show resolved Hide resolved

przemkaczmarek self-assigned this Oct 30, 2024

Add support for user sync

913ea87

bsardo changed the title ~~New bid adapter: Adverxo~~ New Adapter: Adverxo Nov 4, 2024

dev-adverxo added 2 commits November 5, 2024 09:12

Merge remote-tracking branch 'origin/master' into adverxo_adapter

c36f12f

Change packages import references to v3

07b8d6b

przemkaczmarek previously approved these changes Nov 5, 2024

View reviewed changes

bretg requested changes Nov 7, 2024

View reviewed changes

dev-adverxo requested a review from bretg November 7, 2024 17:38

Add aliases for partners

4fc858b

dev-adverxo dismissed przemkaczmarek’s stale review via 4fc858b November 8, 2024 13:44

dev-adverxo requested a review from przemkaczmarek November 8, 2024 14:21

Add new alias

7b84702

przemkaczmarek reviewed Dec 12, 2024

View reviewed changes

static/bidder-info/adverxo.yaml Show resolved Hide resolved

przemkaczmarek reviewed Dec 12, 2024

View reviewed changes

bsardo added the adapter label Jan 6, 2025

przemkaczmarek approved these changes Jan 7, 2025

View reviewed changes

bretg removed their request for review January 7, 2025 15:05

bsardo assigned VeronikaSolovei9 Jan 9, 2025

dev-adverxo mentioned this pull request Jan 13, 2025

AdverxoAdapter: Change pbs to true prebid/prebid.github.io#5807

Open

7 tasks

VeronikaSolovei9 approved these changes Jan 13, 2025

View reviewed changes

bsardo merged commit f49410b into prebid:master Jan 14, 2025
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jan 14, 2025

Port PR from PBS-Go: New Adapter: Adverxo prebid/prebid-server-java#3677

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Adverxo #4018

New Adapter: Adverxo #4018

dev-adverxo commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

github-actions bot commented Nov 4, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

dev-adverxo commented Nov 5, 2024

bretg left a comment

dev-adverxo commented Nov 7, 2024

github-actions bot commented Nov 8, 2024

dev-adverxo commented Nov 8, 2024

github-actions bot commented Nov 11, 2024

dev-adverxo commented Nov 18, 2024

bretg commented Nov 18, 2024

przemkaczmarek Dec 12, 2024

przemkaczmarek Dec 12, 2024

przemkaczmarek Dec 12, 2024

dev-adverxo Dec 16, 2024 •

edited

Loading

dev-adverxo commented Jan 7, 2025

VeronikaSolovei9 commented Jan 11, 2025

dev-adverxo commented Jan 13, 2025

VeronikaSolovei9 left a comment

dev-adverxo commented Jan 14, 2025 •

edited

Loading

		@@ -0,0 +1,9 @@
		endpoint: "https://adport.pbsadverxo.com/auction?id={{.AdUnit}}&auth={{.TokenID}}"

		@@ -0,0 +1,22 @@
		endpoint: "https://pbsadverxo.com/auction?id={{.AdUnit}}&auth={{.TokenID}}"

New Adapter: Adverxo #4018

New Adapter: Adverxo #4018

Conversation

dev-adverxo commented Oct 28, 2024

Summary

github-actions bot commented Oct 28, 2024

Code coverage summary

adverxo

github-actions bot commented Nov 4, 2024

Code coverage summary

adverxo

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

Code coverage summary

adverxo

dev-adverxo commented Nov 5, 2024

bretg left a comment

Choose a reason for hiding this comment

dev-adverxo commented Nov 7, 2024

github-actions bot commented Nov 8, 2024

Code coverage summary

adverxo

dev-adverxo commented Nov 8, 2024

github-actions bot commented Nov 11, 2024

Code coverage summary

adverxo

dev-adverxo commented Nov 18, 2024

bretg commented Nov 18, 2024

przemkaczmarek Dec 12, 2024

Choose a reason for hiding this comment

przemkaczmarek Dec 12, 2024

Choose a reason for hiding this comment

przemkaczmarek Dec 12, 2024

Choose a reason for hiding this comment

dev-adverxo Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

dev-adverxo commented Jan 7, 2025

VeronikaSolovei9 commented Jan 11, 2025

dev-adverxo commented Jan 13, 2025

VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

dev-adverxo commented Jan 14, 2025 • edited Loading

dev-adverxo Dec 16, 2024 •

edited

Loading

dev-adverxo commented Jan 14, 2025 •

edited

Loading