Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admatic: Add headers #4083

Merged
merged 65 commits into from
Jan 28, 2025
Merged

Admatic: Add headers #4083

merged 65 commits into from
Jan 28, 2025

Conversation

bakicam
Copy link
Contributor

@bakicam bakicam commented Dec 1, 2024

No description provided.

bakicam and others added 30 commits May 2, 2024 11:46
@bakicam
admatic s2s
d7218f0
@bakicam
Merge branch 'prebid:master' into master
594a808
@bakicam
Update admatic.go
546cda3
@bakicam
formatted jsons
435b598
@bakicam
fmt
dbec2de
@farukcam
Merge branch 'prebid:master' into master
c05d833
@bakicam
Update admatic.go
094bd52
@bakicam
Merge branch 'master' of https://github.com/Admatic-Sofware/prebid-se…
87dd911 
…rver
@farukcam
Merge branch 'prebid:master' into master
49b9c49
@bakicam
impIDs
bc0468f
@bakicam
Merge branch 'master' of https://github.com/Admatic-Sofware/prebid-se…
f6caf06 
…rver
@farukcam
Merge branch 'prebid:master' into master
801a99c
@bakicam
Update admatic.json
60a434c
@bakicam
Merge branch 'master' of https://github.com/Admatic-Sofware/prebid-se…
331f4f0 
…rver
@farukcam
Merge branch 'prebid:master' into master
4fb522c
@bakicam
Update admatic.go
ac61d1c
@bakicam
Update admatic.go
f978cf0
@bakicam
Update admatic.yaml
f025b87
@bakicam
Update admatic.go
b02724b
@bakicam
Update admatic.go
63387d3
@farukcam
Merge branch 'prebid:master' into master
6754f16
@farukcam
Merge branch 'prebid:master' into master
c5a8a1e
@farukcam
Merge branch 'prebid:master' into master
61369b4
@farukcam
Merge branch 'prebid:master' into master
41258e8
@farukcam
Merge branch 'prebid:master' into master
6d11972
@farukcam
Merge branch 'prebid:master' into master
fbb1c27
@farukcam
Merge branch 'prebid:master' into master
186ce42
@farukcam
Merge branch 'prebid:master' into master
a3c2dd9
@farukcam
Merge branch 'prebid:master' into master
ac73568
@farukcam
Merge branch 'prebid:master' into master
6577bc0
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2e17308

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 686ebd0

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2f962c9

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 13ec60c

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f41426b

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5127e2f

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 981b35e

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@farukcam
Copy link
Contributor

Hello @bsardo,
When can this update be released? We will have new adapter additions, we have to wait for this to be released. Thank you for your interest.

@bsardo
Copy link
Collaborator

bsardo commented Jan 24, 2025

Hello @bsardo, When can this update be released? We will have new adapter additions, we have to wait for this to be released. Thank you for your interest.

Hi @farukcam, we will review and try to get this into next week's release.

guscarreon
guscarreon previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo
Copy link
Collaborator

bsardo commented Jan 24, 2025

@farukcam @bakicam please see this comment.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fe786a5

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			88.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			90.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6e30190

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			92.4%

@farukcam
Copy link
Contributor

@farukcam @bakicam please see this comment.

Hi @bsardo,
We have made improvements on this issue

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6e30190

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:22:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:34:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/admatic/admatic.go:141:	getMediaTypeForBid		88.9%
total:									(statements)			92.4%

guscarreon
guscarreon approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit aaac978 into prebid:master Jan 28, 2025
5 of 6 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guscarreon guscarreon guscarreon approved these changes

@bsardo bsardo bsardo approved these changes

Assignees

@bsardo bsardo

@guscarreon guscarreon

Labels
adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakicam @farukcam @bsardo @guscarreon