Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adnuntius: Copy advertiserDomains to ORTB bid response adomain #4113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adnuntius: Copy advertiserDomains to ORTB bid response adomain #4113

wants to merge 1 commit into from
+35 −17

Conversation

antosarho
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e95c81b

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:100:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:110:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:114:	setHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:130:	makeEndpointUrl		92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:179:	getImpSizes		90.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:202:	generateRequests	92.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:318:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:345:	getSiteExtAsKv		80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:355:	getGDPR			92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:380:	generateReturnExt	86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:414:	generateAdResponse	81.5%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:487:	generateBidResponse	88.0%
total:									(statements)		89.3%

@antosarho antosarho force-pushed the useAdvertiserDomains branch from e95c81b to e316853 Compare December 17, 2024 00:02
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e316853

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:100:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:110:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:114:	setHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:130:	makeEndpointUrl		92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:179:	getImpSizes		90.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:202:	generateRequests	92.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:318:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:345:	getSiteExtAsKv		80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:355:	getGDPR			92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:380:	generateReturnExt	86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:414:	generateAdResponse	78.3%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:480:	generateBidResponse	88.0%
total:									(statements)		89.1%

@przemkaczmarek przemkaczmarek self-assigned this Dec 17, 2024
@bsardo bsardo added the adapter label Jan 6, 2025
@bsardo bsardo changed the title Adnuntius: use advertiserDomains from ad response in otb adomain parameter Adnuntius: Copy advertiserDomains to ORTB bid response adomain Jan 24, 2025
guscarreon
guscarreon reviewed Jan 24, 2025
View reviewed changes
adapters/adnuntius/adnuntius.go
@@ -458,13 +459,6 @@ func generateAdResponse(ad Ad, imp openrtb2.Imp, html string, request *openrtb2.
}}
}

adDomain := []string{}
for _, url := range ad.DestinationUrls {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like destinationUrls is getting replaced by advertiserDomains. Do you foresee destinationUrls to still be used for any other purpose in the future? If not, could we remove the destinationUrls instances from the JSON files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guscarreon guscarreon guscarreon left review comments

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@guscarreon guscarreon

@przemkaczmarek przemkaczmarek

Labels
adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antosarho @guscarreon @przemkaczmarek @bsardo