-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.0 #31
Merged
Merged
Release v2.0.0 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update steps in installation and also some paths * Incorporate review comments
* Update and fix versions used in CI * Fix formatting to satisfy clang format * Fix formatting to satisfy markdown linting
* Resolve deprecations in DuMux 3.6 Use new problem structure for freeflow model * Reintroduce compatibility with DuMux 3.4/3.5 --------- Co-authored-by: Ishaan Desai <[email protected]>
* [ci] Use DUNE 2.9 for DuMux 3.7-git * [examples] Include header for UMFPack linear solver * [examples] Use UMFPack from istlsolvers.hh * [examples] cleanup, satisfy clang format * [ci] build docker dune 2.9 with latest precice * [docker] change dune-subgrid source to dune-project.org/extensions * [docker] deactivate DUNE python bindings for testing
* Modifying docker container recipe to work with precice:develop * Removing old preCICE CMake configurations * Remove binprecice md from Docker recipes
* Update the adapter according to preCICE V3 * tweaking on the format * improve formatting * Add related item in changelog * Change the required preCICE version from 2.0.0 to 3.0.0 * Tweak the formatting of markdown file * Modify the indentation in changelog * Modify the indentation in changelog * Modify the passed parameter to get rid of change to mesh- and dataName * Modify the examples and an error in the adapter itself * Update the required preCICE version CMakeLists.txt * rename some of the functions * changed the preCICE version required and the test to be run * Changed the preCICE version for build-and-test-dumux-master * Using develop version of preCICE in CI * Use preCICE version develop in build-and-test CI --------- Co-authored-by: Jun Chen <[email protected]> Co-authored-by: Ishaan Desai <[email protected]>
…les (#30) * Remove old .gitlab folder * Revert to using std::string and std::vector in adapter API functions * Correct mistake in std:vectpr * Formatting * Revert to using std::string and std:vector instead of precice:: * Use std::string instead of precice::string_view in the dummy solver * Update dumux-precice/couplingadapter.cc Co-authored-by: mathiskelm <[email protected]> * Update examples/dummysolver/main_dummysolver.cc Co-authored-by: mathiskelm <[email protected]> * Clean up dummy solver * Using the correct data types * Further simplifying variable definitions in examples * Formatting * Formatting * Update dumux-precice/couplingadapter.cc Co-authored-by: mathiskelm <[email protected]> * Update dumux-precice/couplingadapter.hh Co-authored-by: mathiskelm <[email protected]> * Update examples/ff-pm/flow-over-cube-3d/main_ff-reversed.cc Co-authored-by: mathiskelm <[email protected]> * Update examples/ff-pm/flow-over-cube-3d/main_pm-reversed.cc Co-authored-by: mathiskelm <[email protected]> * Removing last traces of _View variables from example codes * Use string literals in adapter API of the problem files (*.hh) --------- Co-authored-by: mathiskelm <[email protected]>
#27) * [cmake] use dune_enable_all_packages to export libdumux-precice as module library * [doc] explain usage in separate module * [doc] correct adapter paths * [doc] correct external usage documentation * [cmake] cleanup CMakeLists.txt, remove explicit library link * [doc] clarify instructions for external usage * Update doc/user/docs/installation.md Co-authored-by: Ishaan Desai <[email protected]> --------- Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Jun Chen <[email protected]>
Fujikawas
force-pushed
the
dumux-adapter-v2.0.0
branch
from
March 12, 2024 13:53
d72d1da
to
8900f1a
Compare
mathiskelm
reviewed
Mar 12, 2024
mathiskelm
force-pushed
the
dumux-adapter-v2.0.0
branch
from
March 12, 2024 16:27
882f1ee
to
a540974
Compare
mathiskelm
force-pushed
the
dumux-adapter-v2.0.0
branch
2 times, most recently
from
March 13, 2024 12:24
3d5bf7f
to
52c8085
Compare
mathiskelm
force-pushed
the
dumux-adapter-v2.0.0
branch
from
March 13, 2024 12:40
52c8085
to
8e21cd2
Compare
IshaanDesai
reviewed
Mar 13, 2024
IshaanDesai
reviewed
Mar 13, 2024
IshaanDesai
approved these changes
Mar 13, 2024
mathiskelm
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dumux-adapter comes to v2.0.0 to work with preCICE v3.0.0 and DuMuX from version 3.7. Outdated information are removed.
Checklist
CHANGELOG.md
)