Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base class for Micro Manager and restructure main #111

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

tjwsch
Copy link
Collaborator

@tjwsch tjwsch commented Jun 5, 2024

In preparation for the Snapshot computation #101 this PR adds base classes to reduce code repetitions. This introduces a new interface class MicroManagerInterface, a base class MicroManager and renames the original MicroManager class in MicroManagerCoupling. The PR also changes the structure and position of the main-method to allow snapshot execution via a flag as suggested in #101.

This is also done with the idea to extend this base class in a potential future restructuting process of the MicroManagerCoupling class.

Feedback on how to implement the base classes in clean way is highly apprecitated as I wasn't able to find examples or best practices regarding this scenario, in which a base class handles part of a constrcutor.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@tjwsch tjwsch marked this pull request as ready for review June 5, 2024 13:34
@tjwsch tjwsch requested a review from IshaanDesai June 5, 2024 13:34
@IshaanDesai IshaanDesai added the enhancement Enchance existing functionality label Jun 5, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 good to go after the CHANGELOG entry is reworded!

Co-authored-by: Ishaan Desai <[email protected]>
@tjwsch tjwsch merged commit 18fbdec into develop Jun 6, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the snapshot_preparation branch June 6, 2024 10:18
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enchance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants