Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check if the time window has completed #118

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jul 26, 2024

Currently, the Micro Manager understands that a time window has converged when the API call requires_reading_checkpoint() is false. However, requires_reading_checkpoint() may return false when the time window has not converged. This could happen, for example, when the Micro Manager is subcycling. To avoid falsely indicating convergence in the Micro Manager, an explicit check using the API command is_time_window_complete() is necessary.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Jul 26, 2024
@IshaanDesai IshaanDesai added the bug Something isn't working label Jul 26, 2024
@IshaanDesai IshaanDesai changed the title Explicitly check in solve() if the time window has completed Explicitly check if the time window has completed Jul 26, 2024
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Before there was clearly something wrong if you are using subcycling.

micro_manager/micro_manager.py Show resolved Hide resolved
@IshaanDesai IshaanDesai merged commit 32fd930 into develop Jul 30, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the output_end_tw branch July 30, 2024 05:48
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants