-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change logging strategy and add new logging for adaptivity metrics #133
Conversation
Would be good to put the "number of active simulations" into a format which is more machine-readable than the current text style. |
Could precice/precice#2015 be an alternative technical solution? |
Potentially yes. I have implemented something very close to this, with additionally handling logging in parallel. Would it be possible to tell preCICE to log somethings only on one rank, and other things on all ranks? Also, such logging API would need to be added to the Python bindings. |
Yes, this is part of the runtime configuration for the existing preCICE logging already now. |
This PR adds the following:
Logger
class. In this class, a logger is generated and logging options are provided for logging via one one rank, any rank of choice, or all ranks. Different types of logging are possible. Currently the options areinfo
anderror
.config_file_name
toprecice_config_file_name
to differentiate it from the Micro Manager JSON configuration file.output_cpu_time
toadaptivity_settings
which will output CPU time of the adaptivity computation on every rank. The data is written to preCICE with the intention of being exported. All the micro simulations (coupling vertices) on one rank will have the same scalar value of the adaptivity computation CPU time.micro_sim_time
tosolve_cpu_time
.Checklist:
CHANGELOG.md
.