-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh connectivity for preCICE v3 #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
added
the
compatibility
Affecting only specific OpenFOAM / preCICE versions
label
Jul 25, 2023
davidscn
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good (haven't tested it). Only minor comments below.
This was referenced Jul 27, 2023
fsimonis
reviewed
Aug 4, 2023
Co-authored-by: Frédéric Simonis <[email protected]>
After #285 is merged, I would rebase this branch and merge it next. |
2 tasks
The CI is expected to fail because it is using preCICE v2.5.0. I will update this in a separate PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With preCICE v2, the adapter does:
With this PR (and preCICE v3), the adapter does:
std::map
from vertices (std::tuple
ofdouble
-triplets (coordinates)) to vertex IDs, initializing the vertex IDs to -1.I ran the
flow-over-heated-plate-nearest-projection
tutorial and the results look similar. Comparing all VTK files with fieldcompare, I get some successes, some failures where the difference is on the last digit, and some failures where just fieldcompare could not open the files.co-authored by @fsimonis
Depends on #285
Closes #258.
TODO list:
docs/
-> N/Achangelog-entries/
(create directory if missing)