Skip velocity object from the initializer list #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Fujikawas noticed that the volume-coupled flow tutorial was failing early on, complaining that it could not find
U_vol
when adding coupling data readers.In the original implementation (#270), the velocity was not initialized in the initializer list of the
Velocity
constructor, but it was deferred to the body, where it was created if needed. This is actually needed when reading source terms, since we need a temporary object to read data from preCICE.In the follow-up extension #281, the OpenFOAM velocity object was added to the initializer list, at which point it tries to find an object that (intentionally) does not exist at that point. @thesamriel do I overlook any other reason this was added again into the initializer list?
TODO list:
docs/
-> N/Achangelog-entries/
(create directory if missing)