Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-format pre-commit hook #331

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add clang-format pre-commit hook #331

merged 2 commits into from
Jun 20, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jun 19, 2024 •
edited
Loading

Somehow this was missing so far, even though pre-commit was already set up in this repo.

TODO list:

  • I updated the documentation in docs/ -> The CONTRIBUTING.md already referes to pre-commit for formatting.
  • I added a changelog entry in changelog-entries/ (create directory if missing)

@MakisH MakisH added the dev Not directly affecting users, but helping future development label Jun 19, 2024
@MakisH MakisH requested review from fsimonis and davidscn June 19, 2024 14:41
@MakisH MakisH self-assigned this Jun 19, 2024
@MakisH MakisH merged commit e379848 into precice:develop Jun 20, 2024
4 checks passed
@MakisH MakisH deleted the pre-commit-format branch June 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidscn davidscn davidscn approved these changes

@fsimonis fsimonis fsimonis approved these changes

Assignees

@MakisH MakisH

Labels
dev Not directly affecting users, but helping future development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MakisH @fsimonis @davidscn