Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-based tutorials: Log list of installed packages #608

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jan 11, 2025

In the run.sh of our Python-based tutorial, we create a venv and install packages. This PR adds a call to pip freeze that writes the list of installed packages (with their versions) into a file called pip-installed-packages.log. This additional information can increase reproducibility.

The log file is not touched by clean.sh, as the respective .venv is also not removed by it. It is also neither a case nor a preCICE log file, to be added to the respective cleaning functions.

This is related to #596.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@MakisH MakisH self-assigned this Jan 11, 2025
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Whether or not to clean is probably debatable, but I understand your reasoning.
I did not try it and did not check whether you caught everything.

@MakisH MakisH merged commit 055c89d into precice:develop Jan 13, 2025
1 check passed
@MakisH MakisH deleted the pip-freeze branch January 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants