WIP support cache-dir as a configurable parameter #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mariusvniekerk, sorry for ignoring this PR, it completely missed my line of sight. You've indeed hit a bit of a bootstrapping problem. Before spawning a set of bad ideas, I would like to ask @baszalmstra if he has some good ideas from an architectural side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-working initial stab at allowing configuring cache-dir via the config file. This hits a few roadblocks due to several of the consumers of the prior version of this function not having access to a Config.
What would be the best path to proceed here?