Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start adding some more tests for version updates #48

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Aug 6, 2024

Continuing the implementation here, but potentially moving it into cf-scripts afterwards.

I've added some interesting test cases with one that is kinda hard to fix: the polars test.

@wolfv
Copy link
Member Author

wolfv commented Aug 6, 2024

OK, actually the polars test is also marked as xfail:

    pytest.param(
        "polars_mixed_selectors",
        "1.1.0",
        marks=pytest.mark.xfail(reason=VARIANT_SOURCES_NOT_IMPLEMENTED),
    ),
    pytest.param(
        "polars_name_selectors",
        "1.1.0",
        marks=pytest.mark.xfail(reason=VARIANT_SOURCES_NOT_IMPLEMENTED),
    ),
    pytest.param(
        "polars_variant_selectors",
        "1.1.0",
        marks=pytest.mark.xfail(reason=VARIANT_SOURCES_NOT_IMPLEMENTED),
    ),

Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, apart from that looks good to me

tests/data/version/embree/expected.yaml Show resolved Hide resolved
tests/data/version/embree/recipe.yaml Show resolved Hide resolved
tests/data/version/jinja2sha/recipe.yaml Show resolved Hide resolved
tests/data/version/mpich/expected.yaml Show resolved Hide resolved
tests/data/version/mpich/recipe.yaml Show resolved Hide resolved
tests/data/version/polars_variant/recipe.yaml Show resolved Hide resolved
@wolfv wolfv merged commit 2205928 into prefix-dev:main Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants