Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for pyproject.toml pixi projects #87

Merged
merged 28 commits into from
Apr 16, 2024

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Mar 27, 2024

If updating documentation:

Fixes #88

@pavelzw
Copy link
Collaborator

pavelzw commented Mar 27, 2024

Hmm, i'm wondering whether we should make this behavior implicit without the need to specify manifest-path...

@ruben-arts
Copy link
Contributor Author

I think we should, but we could make it a next step, just wanted to make sure there was an answer to the question on how to do it.

src/options.ts Outdated
if (existsSync('pixi.toml')) {
manifestPath = 'pixi.toml'
} else if (existsSync('pyproject.toml')) {
manifestPath = 'pyproject.toml'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we validate the existance of a [tool.pixi] table?

@ruben-arts ruben-arts marked this pull request as ready for review April 12, 2024 08:04
@ruben-arts ruben-arts requested a review from pavelzw as a code owner April 12, 2024 08:04
@ruben-arts
Copy link
Contributor Author

How do i trigger the full CI? 😅

README.md Outdated Show resolved Hide resolved
@ruben-arts
Copy link
Contributor Author

Oeh I don't like to add a npm install to all these tests. You okay without reading the toml? @pavelzw

README.md Outdated Show resolved Hide resolved
src/options.ts Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
ruben-arts and others added 2 commits April 12, 2024 11:23
Co-authored-by: Pavel Zwerschke <[email protected]>
Co-authored-by: Pavel Zwerschke <[email protected]>
@pavelzw
Copy link
Collaborator

pavelzw commented Apr 12, 2024

@ruben-arts you need to force tsup to include toml in the transpiled code.

noExternal: [
'@actions/core',
'@actions/exec',
'@actions/cache',
'@actions/io',
'@actions/tool-cache',
'untildify',
'zod'
]

We should look how much larger the transpiled code will be; if it's too much we could also just read the file and check if [tool.pixi.toml] is contained in there

Co-authored-by: Pavel Zwerschke <[email protected]>
@ruben-arts
Copy link
Contributor Author

The index.js has grown with 0.12 Mb.

@pavelzw
Copy link
Collaborator

pavelzw commented Apr 12, 2024

I think that's okay 👍🏻

.gitignore Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
ruben-arts and others added 3 commits April 12, 2024 13:58
Co-authored-by: Pavel Zwerschke <[email protected]>
Co-authored-by: Pavel Zwerschke <[email protected]>
pixi.toml Outdated Show resolved Hide resolved
@pavelzw pavelzw added the enhancement New feature or request label Apr 13, 2024
@pavelzw pavelzw changed the title test: add test to test the pyproject.toml as manifest Add better support for pyproject.toml pixi projects Apr 13, 2024
@pavelzw pavelzw mentioned this pull request Apr 15, 2024
1 task
package.json Outdated Show resolved Hide resolved
@ruben-arts
Copy link
Contributor Author

@pavelzw This should be good now.

Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these comments it looks good.

.github/workflows/test.yml Show resolved Hide resolved
test/pyproject-manifest/pyproject.toml Outdated Show resolved Hide resolved
src/options.ts Outdated Show resolved Hide resolved
@ruben-arts ruben-arts requested a review from pavelzw April 16, 2024 12:29
@pavelzw pavelzw merged commit 632d179 into prefix-dev:main Apr 16, 2024
118 of 121 checks passed
@ruben-arts
Copy link
Contributor Author

Thanks for the support @pavelzw, learned a lot about action development!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for pyproject.toml pixi configurations
2 participants