Rename the Move Relearner specials

[Zeturic]

This renames SelectMoveTutorMon and DisplayMoveTutorMenu to ChooseMonForMoveRelearner and TeachMoveRelearnerMove, respectively.

This is how they're named in pokeemerald, and it avoids SelectMoveTutorMon from being confused with the similar ChooseMonForMoveTutor.

[SatoMew]

The character is called Move Maniac.

[Zeturic]

Are you suggesting that these, plus all of the existing symbols that use the Move Relearner terminology (link) should be renamed to use the "Move Maniac" name instead?

If yes, I would argue that's a downgrade in clarity. ChooseMonForMoveRelearner is more clear than ChooseMonForMoveManiac because people don't actually refer to this guy (or these characters generally) as Move Maniac(s), regardless of what he happens to call himself in-game.

I actually considered going through and renaming everything to Move Reminder (the general term they officially stuck with, and how I personally refer to such characters), but it'd be a much larger change of questionable utility, and I figured consistency with pokeemerald was a more pressing concern, so I didn't.

[SatoMew]

Are you suggesting that these, plus all of the existing symbols that use the Move Relearner terminology (link) should be renamed to use the "Move Maniac" name instead?

Yes, or Move Reminder, but Move Maniac is more accurate in the context of these games.

[GriffinRichards]

If yes, I would argue that's a downgrade in clarity. ChooseMonForMoveRelearner is more clear than ChooseMonForMoveManiac because people don't actually refer to this guy (or these characters generally) as Move Maniac(s), regardless of what he happens to call himself in-game.

it'd be a much larger change of questionable utility, and I figured consistency with pokeemerald was a more pressing concern, so I didn't.

Agreed on both counts.