Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bank03.asm Function Descriptions & Translations #110

Merged
merged 12 commits into from
Jan 11, 2025
Merged

bank03.asm Function Descriptions & Translations #110

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
855a643
bank03.asm Function Descriptions & Translations
tdadvocate Oct 21, 2023
ece4504
Update bank03.asm
tdadvocate Nov 2, 2023
12baccb
Update bank03.asm
tdadvocate Nov 4, 2023
ea55c14
Update bank03.asm - Missed One
tdadvocate Nov 4, 2023
4e9baa9
Update README.md
tdadvocate Nov 4, 2023
41fbbf8
bank03.asm Func/Data/Text Names
tdadvocate Nov 7, 2023
31942b8
bank03.asm 2 Reverts, Translations, & Comments
tdadvocate Nov 7, 2023
6dd17d0
Revert "Update README.md"
tdadvocate Nov 15, 2023
5eb00a5
Revert a few function names
tdadvocate Nov 21, 2023
e4d7988
Merge pull request #1 from pret/master
tdadvocate Nov 21, 2023
a88dd0e
Corrections & Additions from vulcandth
tdadvocate Nov 24, 2023
b884744
Vulcandth bank03.asm sugggestions & build fix
tdadvocate Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 50 additions & 50 deletions engine/dumps/bank03.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2270,7 +2270,7 @@ _BillsPC:
ret

Texte224:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if you are unsure of the translation, you can still use it as a label for now.

Suggested change
Texte224:
WhatAreYouGoingToDoText:

text "なんに　するん？"
text "なんに　するん？" ; (lit. "What are you going to do?")
done

Datae22e:
Expand All @@ -2285,29 +2285,29 @@ Datae236:
dw Texte23e

Texte23e:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably has to do with that stats screen.. but just do this for now.

Suggested change
Texte23e:
LookAtPokemonText:

db "#の　ようすをみる@"
db "#の　ようすをみる@" ; (lit "look at Pokemon")

Texte248:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Texte248:
WithdrawMonText:

Eventually these labels might evolve to include "BillsPC" or something to that effect... but until we confirmed they are related.. just keep it simple for now.

db "#を　つれていく@"
db "#を　つれていく@" ; "Withdrawal (Pokemon)"

Texte251:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Texte251:
DepositMonText:

db "#を　あずける@"
db "#を　あずける@" ; "Deposit (Pokemon)"

Texte259:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Texte259:
ReleaseMonText:

db "#を　にがす@"
db "#を　にがす@" ; "Release (Pokemon)"

Texte260:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Texte260:
ChangeBoxText:

db "ボックスを　かえる@"
db "ボックスを　かえる@" ; "Change Box"

Texte26a:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Texte26a:
GoodbyeText:

db "さようなら@"

Tablee270:
dw Functione5c5
dw Functione31b
dw Functione2a6
dw Functione37b
dw Functione3c3
dw Functione2a6 ; Bill's PC > Deposit Pokemon menu item
dw Functione37b ; Bill's PC > Release Pokemon menu item
dw Functione3c3 ; Bill's PC > Box Change menu item
vulcandth marked this conversation as resolved.
Show resolved Hide resolved
dw Functione2a4

Datae27c:
Expand All @@ -2331,7 +2331,7 @@ Functione2a4:
scf
ret

Functione2a6:
Functione2a6: ; Bill's PC > Deposit Pokemon menu item
call Functione2b0
jr c, .sub_e2ae
call Functione2f0
Expand All @@ -2353,7 +2353,7 @@ Functione2b0:
scf
ret
.sub_e2c4
ld hl, Texte2dc
ld hl, Texte2dc ; failed deposit last mon
vulcandth marked this conversation as resolved.
Show resolved Hide resolved
call MenuTextBoxBackup
scf
ret
Expand All @@ -2362,15 +2362,15 @@ Texte2cc:
text "１ぴきも　もってへんやんか！"
prompt

Texte2dc:
text "それ　あずけたら"
Texte2dc: ; failed deposit last mon
text "それ　あずけたら" ; telling you that you can't deposit your last mon
line "こまるんとちゃう？"
prompt

Functione2f0:
call LoadStandardMenuHeader
ld hl, Tablee6da
call Functione6a4
call Functione6a4 ; has something to do with releasing mon from PC
vulcandth marked this conversation as resolved.
Show resolved Hide resolved
call CloseWindow
ret c
ld a, [wScrollingMenuCursorPosition]
Expand Down Expand Up @@ -2413,7 +2413,7 @@ Texte336:
Functione350:
call LoadStandardMenuHeader
ld hl, Datae6f8
call Functione6a4
call Functione6a4 ; has something to do with releasing mon from PC
call CloseWindow
ret c
ld a, [wScrollingMenuCursorPosition]
Expand All @@ -2429,21 +2429,21 @@ Functione350:
call Functiondecd
ret

Functione37b:
Functione37b: ; Bill's PC > Release Pokemon menu item
call .sub_e380
and a
ret
.sub_e380
call LoadStandardMenuHeader
ld hl, Datae6f8
call Functione6a4
call Functione6a4 ; has something to do with releasing mon from PC
call CloseWindow
ld a, [wScrollingMenuCursorPosition]
ld [wWhichPokemon], a
ld a, [wMenuSelection]
ld [wMonDexIndex], a
ret c
ld hl, Texte3af
ld hl, Texte3af ; confirm release of mon
call MenuTextBox
call YesNoBox
call CloseWindow
Expand All @@ -2453,19 +2453,19 @@ Functione37b:
call Functiondecd
ret

Texte3af:
Texte3af: ; confirm release of mon
text_from_ram wStringBuffer1
text "　をほんとうに"
text "　をほんとうに" ; essentially confirming if you want to release the mon
next "にがしますか？"
done

Functione3c3:
call Functione3c8
Functione3c3: ; Bill's PC > Box Change menu item?
call Functione3c8 ; has something to do with dummy boxes in box change screen
and a
ret

Functione3c8:
call Functione3ed
Functione3c8: ; has something to do with dummy boxes in box change screen
call Functione3ed ; probably creating the 4 dummy boxes in change box screen but unsure
call LoadStandardMenuHeader
call ClearPalettes
call ClearTileMap
Expand All @@ -2476,18 +2476,18 @@ Functione3c8:
ld a, [wMenuJoypad]
cp $02
jr z, .sub_e3e9
call Functione505
call Functione505 ; box editing menu function
jr .sub_e3d4
.sub_e3e9
call CloseWindow
ret

Functione3ed:
Functione3ed: ; probably creating the 4 dummy boxes in change box screen but unsure
ld hl, wd4b9
ld c, $00
.sub_e3f2
push hl
ld de, Texte40c
ld de, Texte40c ; used for name of 4 dummy boxes (all clones of box 1)
call CopyString
ld a, $f6
add c
Expand All @@ -2503,8 +2503,8 @@ Functione3ed:
jr c, .sub_e3f2
ret

Texte40c:
db "ダミーボックス@"
Texte40c: ; used for name of 4 dummy boxes (all clones of box 1)
db "ダミーボックス@" ; "Dummy Box"

Datae414:
db $40, $00, $00, $0c, $13, $1c, $64, $01
Expand Down Expand Up @@ -2603,17 +2603,17 @@ Datae4e7:
db $03, $d8, $af
db $03, $20, $b5

Functione505:
ld hl, Datae5a5
Functione505: ; box editing menu function
ld hl, Datae5a5 ; box editing menu list
call LoadMenuHeader
call VerticalMenu
call CloseWindow
ret c
ld a, [w2DMenuDataEnd]
cp $01
jr z, Functione53e
jr z, Functione53e ; box change function
cp $02
jr z, Functione57e
jr z, Functione57e ; box name change screen display function
and a
ret

Expand All @@ -2623,30 +2623,30 @@ Functione51f:
call CloseWindow
ret

Texte529:
Texte529: ; confirming box was changed successfully
text "バンクチェンジは"
next "かいはつちゅうです！"
prompt

Functione53e:
ld hl, Texte551
Functione53e: ; box change function
ld hl, Texte551 ; asking to save game data before box change
call MenuTextBox
call YesNoBox
call CloseWindow
ret c
jr Functione51f
jr Functione51f ; confirming box was changed successfully

Functione54d:
ld a, [wMenuSelection]
ret

Texte551:
Texte551: ; asking to save game data before box change
text "#　ボックスを　かえると"
line "どうじに　レポートが　かかれます"
para "<⋯⋯>　それでも　いいですか？"
done

Functione57e:
Functione57e: ; box name change screen display function
ld b, $04
ld de, wMovementBufferCount
ld a, BANK(NamingScreen)
Expand All @@ -2664,16 +2664,16 @@ Functione57e:
call CopyString
ret

Datae5a5:
Datae5a5: ; box editing menu list
db $40, $06, $00, $0e, $0e
dw Datae5ad
dw Datae5ad ; box editing menu list items
db $01

Datae5ad:
Datae5ad: ; box editing menu list items
db $80, $03
db "ボックスきりかえ@"
db "なまえを　かえる@"
db "やめる@"
db "ボックスきりかえ@" ; "Change Box"
db "なまえを　かえる@" ; " Change Name"
db "やめる@" ; (lit "stop")

Functione5c5:
call LoadStandardMenuHeader
Expand Down Expand Up @@ -2769,7 +2769,7 @@ Texte697:
text "どの#が　みたいねん？"
done

Functione6a4:
Functione6a4: ; has something to do with releasing mon from PC
ld a, l
ld [wcd70], a
ld a, h
Expand All @@ -2782,20 +2782,20 @@ Functione6a4:
ld a, [hli]
ld h, [hl]
ld l, a
call Function3810
call Function3810 ; in home/scrolling_menu.asm but likely calls the select mon choice for release
ld a, [wMenuJoypad]
cp $02
jr z, .sub_e6ce
ld hl, Texte6d0
ld hl, Texte6d0 ; text after selecting mon to release
call MenuTextBoxBackup
and a
ret
.sub_e6ce
scf
ret

Texte6d0:
text "#を　えらんだ！"
Texte6d0: ; text after selecting mon to release
text "#を　えらんだ！" ; (lit. "I choose <mon name>")
prompt

Tablee6da:
Expand Down