Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 결제 api, 마감상품 모아보기 #24

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Feat: 결제 api, 마감상품 모아보기 #24

merged 6 commits into from
Nov 29, 2024

Conversation

cho1ys
Copy link
Collaborator

@cho1ys cho1ys commented Nov 28, 2024

🧃 Pull Request

🍉 코멘트

  • 결제 api에 필요한 부분 수정
  • 마감상품 모아보기 생성
  • mock데이터 위치 변경
  • query사용 훅 생성

🪿 연관된 이슈

✅ PR 포인트 & 궁금한 점

@cho1ys cho1ys added feat feat fix fix refactor refactor labels Nov 28, 2024
@cho1ys cho1ys self-assigned this Nov 28, 2024
OpenS3same
OpenS3same approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@OpenS3same OpenS3same left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어제 멘토님께서 해주신 말씀을 반영하여 코드리뷰를 진행해보고자 평소보다 더 유심히 코드를 봤습니다만 너무 고생하셨단 말 외에는 다른 의견이나 생각나는 말이 없습니다....ㅎ 아 그리고 마감상품 탭 추가하신 거 정말 좋은것 같습니다 고생하셨습니다!!

sunglitter
sunglitter approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@sunglitter sunglitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다

@cho1ys cho1ys merged commit 2dad1a7 into main Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenS3same OpenS3same OpenS3same approved these changes

@sunglitter sunglitter sunglitter approved these changes

Assignees

@cho1ys cho1ys

Labels
feat feat fix fix refactor refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cho1ys @sunglitter @OpenS3same