use plural resource name for file-download and outbound-link-click ev…

…ents
prismelabs · Dec 10, 2024 · 222f818 · 222f818
1 parent d33ab7a
commit 222f818
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/pkg/handlers/events_file_download.go b/pkg/handlers/events_file_download.go
@@ -17,7 +17,7 @@ import (
 type PostEventsFileDownload fiber.Handler
 
 // ProvidePostEventsFileDownload is a wire provider for POST
-// /api/v1/events/file-download handler.
+// /api/v1/events/file-downloads handler.
 func ProvidePostEventsFileDownload(
 	eventStore eventstore.Service,
 	saltManagerService saltmanager.Service,

diff --git a/pkg/handlers/events_outbound_link.go b/pkg/handlers/events_outbound_link.go
@@ -17,7 +17,7 @@ import (
 type PostEventsOutboundLink fiber.Handler
 
 // ProvidePostEventsOutboundLink is a wire provider for POST
-// /api/v1/events/outbound-link handler.
+// /api/v1/events/outbound-links handler.
 func ProvidePostEventsOutboundLink(
 	eventStore eventstore.Service,
 	saltManagerService saltmanager.Service,

diff --git a/pkg/handlers/noscript_outbound_link.go b/pkg/handlers/noscript_outbound_link.go
@@ -17,7 +17,7 @@ import (
 type GetNoscriptEventsOutboundLink fiber.Handler
 
 // ProvideGetNoscriptEventsOutboundLink is a wire provider for
-// GET /api/v1/noscript/events/outbound-link handler.
+// GET /api/v1/noscript/events/outbound-links handler.
 func ProvideGetNoscriptEventsOutboundLink(
 	eventStore eventstore.Service,
 	sessionStorage sessionstorage.Service,

diff --git a/pkg/wired/fiber.go b/pkg/wired/fiber.go
@@ -49,10 +49,10 @@ func ProvideFiber(
 	app.Post("/api/v1/events/custom/:name", fiber.Handler(postCustomEventHandler))
 	app.Get("/api/v1/noscript/events/custom/:name", fiber.Handler(getNoscriptCustomEventHandler))
 
-	app.Post("/api/v1/events/outbound-link", fiber.Handler(postOutboundLinkEventHandler))
-	app.Get("/api/v1/noscript/events/outbound-link", fiber.Handler(getNoscriptOutboundLinkEventHandler))
+	app.Post("/api/v1/events/outbound-links", fiber.Handler(postOutboundLinkEventHandler))
+	app.Get("/api/v1/noscript/events/outbound-links", fiber.Handler(getNoscriptOutboundLinkEventHandler))
 
-	app.Post("/api/v1/events/file-download", fiber.Handler(postFileDownloadEventHandler))
+	app.Post("/api/v1/events/file-downloads", fiber.Handler(postFileDownloadEventHandler))
 
 	return app
 }
diff --git a/tests/bun/const.ts b/tests/bun/const.ts
@@ -6,9 +6,9 @@ export const PRISME_PAGEVIEWS_URL = PRISME_API_URL + '/events/pageviews'
 export const PRISME_NOSCRIPT_PAGEVIEWS_URL = PRISME_API_URL + '/noscript/events/pageviews'
 export const PRISME_CUSTOM_EVENTS_URL = PRISME_API_URL + '/events/custom'
 export const PRISME_NOSCRIPT_CUSTOM_EVENTS_URL = PRISME_API_URL + '/noscript/events/custom'
-export const PRISME_OUTBOUND_LINK_EVENTS_URL = PRISME_API_URL + '/events/outbound-link'
-export const PRISME_NOSCRIPT_OUTBOUND_LINK_EVENTS_URL = PRISME_API_URL + '/noscript/events/outbound-link'
-export const PRISME_FILE_DOWNLOAD_EVENTS_URL = PRISME_API_URL + '/events/file-download'
+export const PRISME_OUTBOUND_LINK_EVENTS_URL = PRISME_API_URL + '/events/outbound-links'
+export const PRISME_NOSCRIPT_OUTBOUND_LINK_EVENTS_URL = PRISME_API_URL + '/noscript/events/outbound-links'
+export const PRISME_FILE_DOWNLOAD_EVENTS_URL = PRISME_API_URL + '/events/file-downloads'
 
 export const PRISME_METRICS_URL = PRISME_ADMIN_URL + '/metrics'
 

diff --git a/tracker/web_analytics.js b/tracker/web_analytics.js
@@ -147,12 +147,12 @@
       }
 
       // Send event.
-      sendClickEvent("/outbound-link", url).finally(followLink)
+      sendClickEvent("/outbound-links", url).finally(followLink)
     }
 
     // File downloads.
     if (trackFileDownloads && anchor.getAttribute("download") !== null) {
-      return sendClickEvent("/file-download", url)
+      return sendClickEvent("/file-downloads", url)
     }
   }