Traits for witnesses and committed instances #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
winderica
force-pushed
the
witness-instance-traits
branch
from
d07a811 to
4096fb2
Compare
|
Just rebased this PR onto main, and it should be ready for review now! |
dmpierre
approved these changes
Sep 19, 2024
Merged
via the queue into
privacy-scaling-explorations:main
with commit Sep 19, 2024
dfd03ea
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #145 is a huge PR, I would like to separate it into several parts. This PR adds traits
Witness{Var}ExtandCommittedInstance{Var}Ext, serving as abstractions for witnesses and committed instances in Nova, HyperNova and ProtoGalaxy.Looking ahead, the methods in these traits are going to be used by the unified generic decider circuit in #145.
Also, the
hashmethod inCommittedInstance{Var}Exthas a default implementation, so we can eliminate the duplicated code ofhashfor Nova'sCommittedInstance, HyperNova'sLCCCS, and ProtoGalaxy'sCommittedInstance.The signature of
hashis also changed, wherez_0andz_iare now slices rather than owned vectors.In this way, we can avoid cloning
z_iin augmented circuits, asz_imight be very large.