-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Hide view functions from project #1013
base: main
Are you sure you want to change the base?
Conversation
Managing a view from the developer interface was in the original design. We don't want to do this anymore? (ping @tuscland ) |
I agree that it is weird to have those repositories exposed. This is private stuff. However, being able to build views programmatically can be useful. I would like to discuss with Marie offline about her intent in creating this issue. Maybe it is part of a larger project that I am not aware of at the moment. |
I've re-drafted the PR as long as there is an open discussion. |
ad7922d
to
469d1e5
Compare
My intent is to have a library that is as simple as possible for the user. When they see a function, it really provides value to them, it helps them for a given use case they have appart from skore. |
@thomass-dev as discussed with Marie, it is a good decision to reduce the public API space and relegate View to private scope. |
No because #1052 is about the items, while this is about the views. |
OK I see, I got confused because of the related issue (#1045 (comment)) where it is also mentioned that It would really help to have a proper description in PR summary. |
ah, indeed, the TODO was enriched! |
Yes, it is just that we can add |
Will actually be closed by #1052
We have functions about views in project which are documented & public, while we offer no specific feature related to a view. So far, it's something we want to deal with internally.
Suggesting this solution, but not sure it's the best since the view functions still appear in the autocomplete. Also, there is still the "view_repository" as one of the parameters of Project while it would be best to be hidden.