Add testing workflow #374
Merged
Add testing workflow #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again, @thomaspinder. This is a very good suggestion. Unfortunately, we're a bit limited on which versions we support because of our dependencies on JAX and dm-tree (inherited from TensorFlow Probability). JAX officially supports Python 3.10+ and dm-tree does not yet support Python 3.13 (it currently fails to compile). I tried testing on earlier versions of Python anyway, and some did pass even though they're not officially supported by JAX! However, I also ran into some issues with the github test suite not having certain version/architecture combos. Hopefully supporting 3.10-3.12 for now, and adding 3.13 as soon as dm-tree is resolved, will be sufficient for our users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters the testing workflow to consider all supported Python versions. Additionally, tests are executed on a Linux and Mac machine.
As part of my larger review, I suggest increasing the lower bound on supported Python versions. Should this suggested be adopted, then the workflow should be altered to reflect the bump.
This PR is part of my JOSS review: openjournals/joss-reviews#7069