Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary type casting #2815

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 24, 2023

By including the @typescript-eslint/recommended-type-checked rule in pull request #2812, we identify some unnecessary type casting.

Covers #2742

@csouchet csouchet added the refactoring Code refactoring label Aug 24, 2023
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

♻️ PR Preview 90bfa96 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet changed the title refactor: remove unnecessary cast refactor: remove unnecessary type casting Aug 24, 2023
@csouchet csouchet marked this pull request as ready for review August 24, 2023 15:03
@csouchet csouchet requested a review from tbouffard August 24, 2023 15:03
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@csouchet csouchet merged commit 8c27e3a into master Aug 24, 2023
@csouchet csouchet deleted the remove_unnecessary_cast branch August 24, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants