fix: ignore invalid event definition reference #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the parser assumed that the identifier reference in the event definition was valid, i.e. that the identifier was defined at the top level. If this was not the case, the corresponding event definition was not retrieved. The following code attempted to access properties with undefined values. This generated an error.
|
♻️ PR Preview 2453660 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 2453660 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
approved these changes
Jan 18, 2024
tbouffard
commented
Jan 18, 2024
tbouffard
commented
Jan 18, 2024
tbouffard
commented
Jan 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parser assumed that the identifier reference in the event definition was valid, i.e. that the identifier was defined at the top level.
If this was not the case, the corresponding event definition was not retrieved. The following code attempted to access properties with undefined values.
This generated an error.
Notes