Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance test when releasing #1298

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ewjoachim
Copy link
Member

Closes #

During the brief moment where we have a new tag and not the new PyPI release yet, it's exactly the moment where the tag build launches the acceptance tests, and so we need to make sure they can run at that moment too

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@ewjoachim ewjoachim requested a review from a team as a code owner January 24, 2025 22:07
@github-actions github-actions bot added the PR type: miscellaneous 👾 Contains misc changes label Jan 24, 2025
@ewjoachim ewjoachim force-pushed the fix-acceptance-test-when-releasing branch from 1c96e5b to aecb6cb Compare January 24, 2025 22:08
Copy link

github-actions bot commented Jan 24, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@ewjoachim ewjoachim merged commit 3767f7f into main Jan 24, 2025
12 checks passed
@ewjoachim ewjoachim deleted the fix-acceptance-test-when-releasing branch January 24, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: miscellaneous 👾 Contains misc changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant