Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing model and simplify launching Worker from Django #919

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Add missing model and simplify launching Worker from Django #919

merged 4 commits into from
Feb 1, 2024

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented Jan 31, 2024 •
edited
Loading

It's a draft for now.

It does multiple things

  • move some internal code around
  • move the logic for generating an async connector from the django connector to DjangoConnector. This should make it easier to launch a worker without using the manage.py procrastinate cli.
  • Add the ProcrastinatePeriodicDefer Django model

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@ewjoachim ewjoachim force-pushed the get_worker_connector branch from 3347834 to 4cea76b Compare February 1, 2024 14:47
@ewjoachim ewjoachim marked this pull request as ready for review February 1, 2024 14:48
@ewjoachim ewjoachim requested a review from a team as a code owner February 1, 2024 14:48
@github-actions github-actions bot added the PR type: feature ⭐️ Contains new features label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  procrastinate/contrib/django
  apps.py
  django_connector.py 26, 138
  models.py
  utils.py
  procrastinate/contrib/django/management/commands
  procrastinate.py 25-26
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim ewjoachim merged commit b91613e into main Feb 1, 2024
13 checks passed
@ewjoachim ewjoachim deleted the get_worker_connector branch February 1, 2024 14:50
@ewjoachim ewjoachim mentioned this pull request Mar 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR type: feature ⭐️ Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewjoachim