kicad5: allow ALIAS or $FPLIST to be in either order #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Switch.lib shipping with current versions of kicad has some of these in a different order from the expectations of this crate, so add a simple loop that allows them to be in either order relative to each other.
|
Hey, sorry, I totally forgot about your PR. Even worse, I ran into exactly the same issue today and started fixing it myself 🤦♂️ . Thank you for your fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Switch.lib shipping with current versions of kicad
has some of these in a different order from the expectations
of this crate, so add a simple loop that allows them to be
in either order relative to each other.
(This is the same as #3 but against the kicad5 branch)