Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AudioService): Update form-data key to 'file' #1185

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

AkinoKitsu
Copy link
Contributor

Pull Request Description

Updated audio service form-data key to reflect requirements in Fivemanage and Fivemerr docs.
Fivemanage seems to have some flexibility, but Fivemerr will not upload audio correctly unless the key is named file.

Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you built and tested NPWD in-game after the relevant change?

Copy link
Member

@itschip itschip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itschip itschip merged commit bbb5327 into project-error:master Nov 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants