Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completing some isssues + fix in readme #295

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Completing some isssues + fix in readme #295

merged 7 commits into from
Jan 9, 2025

Conversation

SlejmUr
Copy link
Contributor

@SlejmUr SlejmUr commented Jan 9, 2025

Fix null in contributor.md
Add more classes on Location
Add Survey models
Add Exceptions for AbstactCoreHttpController
Add basic CryptoService
Add simple versioncheck.
Add GetEftVersion method in EftHttpContext

@SlejmUr
Fix null in contributor.md
90279c5 
Add more classes on Location
Add Survey models
Add Exceptions for AbstactCoreHttpController
Add basic CryptoService
Add simple versioncheck.
Add GetEftVersion method in EftHttpContext
@SlejmUr
Copy link
Contributor Author

SlejmUr commented Jan 9, 2025

Should complete these:
287

Partially complete these:
290 (Require some Items)
141 & 135 (Need check for it actually works, plus implementation)

SlejmUr added 2 commits January 9, 2025 13:12
@SlejmUr
Fix RequestBodyNotParsable error
a924343 
Implement CryptographyService inside the CoreHttpContext
CryptographyService is now static. (Should we go back to Instance version or its good like this?)
@SlejmUr
Fix Test HttpClient to include version.
d7a3d70
seionmoya
seionmoya requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@seionmoya seionmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Good stuff in there.

I should've mentioned in the CONTRIBUTING docs that abbr. names for Stream derivative types are fine. Sorry for that!

Fuyu.Backend.Core/Services/CryptographyService.cs Show resolved Hide resolved
Fuyu.Backend.Core/Services/CryptographyService.cs Show resolved Hide resolved
Fuyu.Backend.Core/Services/CryptographyService.cs Outdated Show resolved Hide resolved
Fuyu.Backend.EFT/Controllers/Http/CheckVersionController.cs Outdated Show resolved Hide resolved
Fuyu.Backend.EFT/Controllers/Http/CheckVersionController.cs Outdated Show resolved Hide resolved
@seionmoya seionmoya added enhancement New feature or request backend Related to Fuyu.Backend labels Jan 9, 2025
@seionmoya seionmoya added this to the 0.1.0 milestone Jan 9, 2025
@seionmoya
Copy link
Collaborator

Resolves:
#287

Partially resolves:
#135
#141
#290

SlejmUr added 3 commits January 9, 2025 17:34
@SlejmUr
update all csproj to use LangLevel 13. (net9.0)
82d38e4 
Add AesHelper from CryptographyService
Function from CryptographyService to AesHelper.
@SlejmUr
namespace_declarations on file_scoped is producing warnings rather th…
2d528c5 
…an suggestion

+ format code.
@SlejmUr
Merge branch 'dev' into dev
8af780f
@SlejmUr
Copy link
Contributor Author

SlejmUr commented Jan 9, 2025

Resolved conflicts too

@seionmoya seionmoya merged commit a4a7048 into project-fika:dev Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seionmoya seionmoya seionmoya approved these changes

Assignees

@SlejmUr SlejmUr

Labels
backend Related to Fuyu.Backend enhancement New feature or request
Projects
Escape From Tarkov
Status: Done
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SlejmUr @seionmoya