Skip to content

Commit

Permalink
Return nil instead of an empty string from normalized_date (#1513)
Browse files Browse the repository at this point in the history
  • Loading branch information
corylown authored Mar 13, 2024
1 parent ced5a42 commit d2aee08
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/arclight/normalized_date.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def normalize
result << inclusive if inclusive.present?
result << other if other.present?
result << "bulk #{bulk}" if bulk.present?
result.compact.map(&:strip).join(', ')
result.compact.map(&:strip).join(', ').presence
end
end
end
2 changes: 1 addition & 1 deletion spec/lib/arclight/normalized_date_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
let(:date_other) { nil }

it 'does not know what to do' do
expect(normalized_date).to eq ''
expect(normalized_date).to be_nil
end
end
end
Expand Down

0 comments on commit d2aee08

Please sign in to comment.