Merge pull request #1567 from projectblacklight/update-rubocop

Update rubocop config

.rubocop.yml

@@ -2,40 +2,42 @@ require:
   - rubocop-rspec
   - rubocop-rails
   - rubocop-rake
+  - rubocop-rspec_rails
+  - rubocop-capybara
 
 inherit_from:
   - .rubocop_todo.yml
 
 AllCops:
   Exclude:
-    - '.internal_test_app/**/*'
-    - 'bin/**/*'
-    - 'db/**/*'
-    - 'lib/generators/arclight/templates/**/*'
-    - 'vendor/**/*'
-    - 'node_modules/**/*'
+    - ".internal_test_app/**/*"
+    - "bin/**/*"
+    - "db/**/*"
+    - "lib/generators/arclight/templates/**/*"
+    - "vendor/**/*"
+    - "node_modules/**/*"
   TargetRubyVersion: 3.0
   DisplayCopNames: true
 
 Metrics/ModuleLength:
   Exclude:
-    - 'app/helpers/arclight_helper.rb'
-    - 'app/models/concerns/arclight/solr_document.rb'
+    - "app/helpers/arclight_helper.rb"
+    - "app/models/concerns/arclight/solr_document.rb"
 
 Metrics/BlockLength:
   Exclude:
-    - 'arclight.gemspec'
-    - 'lib/arclight/traject/ead2_config.rb'
-    - 'lib/tasks/**/*'
-    - 'spec/features/traject/ead2_indexing_spec.rb'
-    - 'spec/helpers/arclight_helper_spec.rb'
-    - 'spec/features/collection_page_spec.rb'
-    - 'spec/**/*'
-    - 'tasks/**/*'
+    - "arclight.gemspec"
+    - "lib/arclight/traject/ead2_config.rb"
+    - "lib/tasks/**/*"
+    - "spec/features/traject/ead2_indexing_spec.rb"
+    - "spec/helpers/arclight_helper_spec.rb"
+    - "spec/features/collection_page_spec.rb"
+    - "spec/**/*"
+    - "tasks/**/*"
 
 Naming/PredicateName:
   ForbiddenPrefixes:
-    - _is
+    - is_
 
 Layout/LineLength:
   Max: 160
@@ -48,7 +50,7 @@ Bundler/DuplicatedGem:
 
 Style/FormatStringToken:
   Exclude:
-    - 'spec/test_app_templates/lib/generators/test_app_generator.rb'
+    - "spec/test_app_templates/lib/generators/test_app_generator.rb"
 
 Gemspec/DeprecatedAttributeAssignment: # new in 1.30
   Enabled: true
@@ -204,11 +206,11 @@ Capybara/SpecificFinders: # new in 2.13
   Enabled: true
 Capybara/SpecificMatcher: # new in 2.12
   Enabled: true
-RSpec/FactoryBot/SyntaxMethods: # new in 2.7
+FactoryBot/SyntaxMethods: # new in 2.7
   Enabled: true
-RSpec/Rails/AvoidSetupHook: # new in 2.4
+RSpecRails/AvoidSetupHook: # new in 2.4
   Enabled: true
-RSpec/Rails/HaveHttpStatus: # new in 2.12
+RSpecRails/HaveHttpStatus: # new in 2.12
   Enabled: true
 Rails/ActionControllerFlashBeforeRender: # new in 2.16
   Enabled: true
@@ -318,9 +320,9 @@ Capybara/NegationMatcher: # new in 2.14
   Enabled: true
 Capybara/SpecificActions: # new in 2.14
   Enabled: true
-RSpec/FactoryBot/ConsistentParenthesesStyle: # new in 2.14
+FactoryBot/ConsistentParenthesesStyle: # new in 2.14
   Enabled: false # https://github.com/rspec/rspec-rails/issues/2635
-RSpec/Rails/InferredSpecType: # new in 2.14
+RSpecRails/InferredSpecType: # new in 2.14
   Enabled: true
 Rails/ActionOrder: # new in 2.17
   Enabled: true
@@ -354,9 +356,9 @@ RSpec/DuplicatedMetadata: # new in 2.16
   Enabled: true
 RSpec/PendingWithoutReason: # new in 2.16
   Enabled: true
-RSpec/FactoryBot/FactoryNameStyle: # new in 2.16
+FactoryBot/FactoryNameStyle: # new in 2.16
   Enabled: false # https://github.com/rubocop/rubocop-rspec/issues/1587
-RSpec/Rails/MinitestAssertions: # new in 2.17
+RSpecRails/MinitestAssertions: # new in 2.17
   Enabled: true
 Rails/ResponseParsedBody: # new in 2.18
-  Enabled: true
+  Enabled: true