Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "View More/View Less" links as a darker color #1472

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

lfarrell
Copy link
Contributor

Fixes contrast issue

Split out from: #1447

@lfarrell lfarrell mentioned this pull request Dec 11, 2023
@seanaery seanaery self-requested a review December 11, 2023 16:44
Copy link
Contributor

@seanaery seanaery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibble here, but I would generalize this more so institutions who are not using the default Bootstrap blue for links have a better chance of not having to override this style locally.

Looking at Bootstrap's variables it looks like $blue-600 is equivalent to shading the default link color 20% darker, so this should work well:

color: shade-color($link-color, 20%);

@marlo-longley marlo-longley merged commit bd4d858 into main Dec 12, 2023
4 checks passed
@marlo-longley marlo-longley deleted the contrast-issues branch December 12, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants