[WIP] Enable a configuration for skipping a saved search that uses the requ…

app/controllers/concerns/blacklight/search_context.rb

@@ -13,7 +13,7 @@ module Blacklight::SearchContext
 
   class_methods do
     # Save the submitted search parameters in the search session
-    def record_search_parameters opts = { only: :index }
+    def record_search_parameters(opts = { unless: proc { |c| (c.action_name.to_s != "index") || c.send(:skip_session_tracking?) } })
       before_action :set_current_search_session, opts
     end
   end
@@ -39,7 +39,7 @@ def set_current_search_session
   end
 
   def find_search_session
-    if agent_is_crawler?
+    if skip_session_tracking?
       nil
     elsif params[:search_context].present?
       find_or_initialize_search_session_from_params JSON.parse(params[:search_context])
@@ -79,6 +79,20 @@ def agent_is_crawler?
     crawler_proc.call(request)
   end
 
+  def skip_session_tracking?
+    return true if agent_is_crawler?
+
+    skip_session_proc = blacklight_config.skip_session_tracking
+    case skip_session_proc
+    when TrueClass
+      true
+    when Proc
+      skip_session_proc.call(request, params)
+    else
+      false
+    end
+  end
+
   def find_or_initialize_search_session_from_params params
     params_copy = params.reject { |k, v| blacklisted_search_session_params.include?(k.to_sym) || v.blank? }
 

lib/blacklight/configuration.rb

@@ -243,6 +243,11 @@ def default_values
     # @return [Boolean]
     property :track_search_session, default: true
 
+    # @!attribute skip_session_tracking
+    # @since v8.0.0
+    # @return [Boolean]
+    property :skip_session_tracking, default: nil
+
     # @!attribute advanced_search
     # @since v7.15.0
     # @return [#enabled]

spec/features/skip_session_tracking_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+RSpec.describe 'Search session skipping' do
+  describe 'crawler search' do
+    let(:original_proc) { ::CatalogController.blacklight_config.skip_session_tracking }
+
+    before do
+      ::CatalogController.blacklight_config.skip_session_tracking = ->(_req, params) { params.fetch('view', nil) == 'weird_json_view' }
+    end
+
+    after do
+      ::CatalogController.blacklight_config.skip_session_tracking = original_proc
+    end
+
+    it 'remembers most searches' do
+      visit root_path
+      fill_in 'q', with: 'chicken'
+      expect { click_button 'search' }.to change(Search, :count).by(1)
+    end
+
+    it 'does not remember weird json search' do
+      visit root_path
+      expect { visit search_catalog_path(q: 'chicken', view: 'weird_json_view') }.not_to change(Search, :count)
+    end
+  end
+end