feat(float): add step configuration

projectcaluma · Jan 20, 2025 · f885a38 · f885a38
1 parent 361df5f
commit f885a38
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/caluma/caluma_form/models.py b/caluma/caluma_form/models.py
@@ -236,6 +236,14 @@ def color(self):
     def color(self, value):
         self.configuration["color"] = value
 
+    @property
+    def step(self):
+        return self.configuration.get("step") or 0.001
+
+    @step.setter
+    def step(self, value):
+        self.configuration["step"] = value
+
     @property
     def validate_on_enter(self):
         return self.configuration.get("validate_on_enter")

diff --git a/caluma/caluma_form/schema.py b/caluma/caluma_form/schema.py
@@ -457,6 +457,7 @@ class Meta:
 class FloatQuestion(QuestionQuerysetMixin, FormDjangoObjectType):
     min_value = graphene.Float()
     max_value = graphene.Float()
+    step = graphene.Float()
     placeholder = graphene.String()
     hint_text = graphene.String()
     default_answer = graphene.Field("caluma.caluma_form.schema.FloatAnswer")

diff --git a/caluma/caluma_form/serializers.py b/caluma/caluma_form/serializers.py
@@ -335,6 +335,7 @@ class Meta(SaveQuestionSerializer.Meta):
 class SaveFloatQuestionSerializer(SaveQuestionSerializer):
     min_value = FloatField(required=False, allow_null=True)
     max_value = FloatField(required=False, allow_null=True)
+    step = FloatField(required=False, allow_null=True)
 
     def validate(self, data):
         min_value = (
@@ -351,13 +352,21 @@ def validate(self, data):
                 f"max_value {max_value} is smaller than {min_value}"
             )
 
+        step = data.get("step")
+        step = (
+            step
+            if step is not None
+            else 0.001
+        )
+
         data["type"] = models.Question.TYPE_FLOAT
         return super().validate(data)
 
     class Meta(SaveQuestionSerializer.Meta):
         fields = SaveQuestionSerializer.Meta.fields + [
             "min_value",
             "max_value",
+            "step",
             "placeholder",
             "hint_text",
         ]

diff --git a/caluma/caluma_form/tests/test_question.py b/caluma/caluma_form/tests/test_question.py
@@ -93,6 +93,7 @@ def test_query_all_questions(
                 ... on FloatQuestion {
                   floatMinValue: minValue
                   floatMaxValue: maxValue
+                  floatStep: step
                   placeholder
                   hintText
                 }