Feat: update Caluma to Django 4.2 #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Review can be done commit-by-commit, all changes are documented |
Co-Authored-By: Stephan Hug <[email protected]>
winged
force-pushed
the
feat_update_to_django_42
branch
8 times, most recently
from
3c5daae to
d57fe83
Compare
Notable change: replacing `psycopg2` with `psycopg`, version 3 BREAKING CHANGE: This drops support for PostgreSQL versions 9, 10 and 11, as well as Python 3.8. Co-Authored-By: Stephan Hug <[email protected]>
Psycopg3 is imported as `psycopg`, and has a few differences that we fix here
The `USE_L10N` setting is deprecated in Django 5 and causes deprecation warnings when kept. And it's Django's default behaviour since ages, so no ill effects here Co-Authored-By: Stephan Hug <[email protected]>
Co-Authored-By: Stephan Hug <[email protected]>
The `nulls_first` / `nulls_last` params now want `True` or `None` instead of `True`/`False`, so that's what we do ¯\_(ツ)_/¯
The exception types and messages changed a bit with Django 4.2
This command will never be run again, so I'm `xfail`in the test and marking it as "no cover". There are no old Caluma installations that haven't been migrated, so we don't even care that the command doesn't seem to work properly in Django 4.2+ any more
This is basically a no-op, just Django cleaing up some old stuff. Previously, the `related_name` was set to some value that's invalid/unused now, but hasn't been detected in a long time.
Django 4.2 does not support PostgreSQL versions older than 12. Also, Python 3.8 will be EOL'd soon, so we're dropping that one as well.
The django-localized-fields app enables the hstore extension in the DB, and therefore must run first. This was probably only "accidentally correct" before, but now it's explicit. Fixes DB migration issues on fresh,clean databases. Co-authored-by: Jean-Louis Fuchs <[email protected]>
Co-authored-by: Jean-Louis Fuchs <[email protected]>
We can't do anything about it right now, as it seems to be in graphene, not our code. Also it's a while until python 3.14, so we can wait a bit until Graphene is updated
The analytics table here doesn't do ordering in SQL, so we should not assume sorted output.
winged
force-pushed
the
feat_update_to_django_42
branch
from
d57fe83 to
136f1ae
Compare
|
Note: With this, we're dropping support for PostgreSQL versions older than 12, and Python 3.8 is also no longer supported. See message of commit caf6a12 |
derrabauke
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the initial work, @StephanH90