Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement El Farol model #69

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Implement El Farol model #69

merged 1 commit into from
Nov 29, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 25, 2023

This is based on projectmesa/mesa#1057, with changes:

  • Updated to the new Mesa API
  • Used Seaborn instead of Matplotlib
  • Deduplicated code
  • Added clarifying comments
  • Removed the MultiGrid space because it is not needed in this model
  • Added test

I confirmed that for the non-IBL version:

However, for the IBL version, the plot
2023-11-25T02:56:21,177096122-05:00
does not reproduce figure 1 in Kumar 2016
2023-11-25T03:06:58,817819302-05:00

Either:

  • Drop the IBL version for now, redo it in a separate repo and separate folder
  • merge this PR with the caveat in the README.md saying that the IBL version is still problematic

cc: @danielxu05

@rht
Copy link
Contributor Author

rht commented Nov 25, 2023

I have decided to drop the IBL version for now, until I have figured out the bugs. This is a safer route, and that the PR becomes more compact as well.

@rht
Copy link
Contributor Author

rht commented Nov 25, 2023

Removed the IBL code. This PR is ready.

Co-authored-by: Daniel Xu <[email protected]>
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*note for records --- IBL is Instance Based Learning

@tpike3 tpike3 merged commit 63326dc into projectmesa:main Nov 29, 2023
2 checks passed
@rht rht deleted the el_farol branch November 29, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants