-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add godot linter #3613
Add godot linter #3613
Conversation
Good to know it works 😄
|
0719d20
to
9c6c034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request to fix a few incorrect doc comments, otherwise LGTM.
This needs a rebase. Also, would you mind squashing all the fixes into one commit? |
8ef7063
to
e696e25
Compare
Signed-off-by: George Robinson <[email protected]>
e696e25
to
e8c8554
Compare
Signed-off-by: George Robinson <[email protected]>
e279404
to
b4bde95
Compare
@grobinson-grafana ping |
@TheMeier I don't have merge permissions so I can't merge this 😞 Needs to be @gotjosh or @simonpasquier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add godot linter Signed-off-by: George Robinson <[email protected]> * Remove extra line from LICENSE Signed-off-by: George Robinson <[email protected]> --------- Signed-off-by: George Robinson <[email protected]> Signed-off-by: Gokhan Sari <[email protected]>
Adds the
godot
linter to make sure all comments are captialized and end in a full stop (period).