Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for regex character classes #4155

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Dec 6, 2024

This pull request adds additional tests for the questions asked in https://groups.google.com/g/prometheus-users/c/Ra0oiVpVur8.

@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-tests-for-regex-character-classes branch 2 times, most recently from c7773cd to e10c393 Compare December 6, 2024 13:08
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-tests-for-regex-character-classes branch from e10c393 to e1034f9 Compare December 6, 2024 13:09
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gotjosh gotjosh merged commit ec9a21e into prometheus:main Dec 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants