Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger event for hidden elements #36

Closed
wants to merge 1 commit into from
Closed

Don't trigger event for hidden elements #36

wants to merge 1 commit into from

Conversation

caseyWebb
Copy link

Passes all tests

[ref] #6

@robertfausk
Copy link

@tiff What about merging this PR? I would really appreciate this one.

@tiff
Copy link
Member

tiff commented Jan 26, 2016

this would not trigger the inview event for elements that have zero height (since :visible is based on that). not sure if I want this :)

@caseyWebb caseyWebb closed this Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants