Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace new exampleIP for example.org #14795

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

syjn99
Copy link
Contributor

@syjn99 syjn99 commented Jan 15, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This PR makes TestHostIsResolved happy by replacing IP for example.org. I'm not sure why its IP keeps changing every year.

❯ dig example.org @a.iana-servers.net

; <<>> DiG 9.10.6 <<>> example.org @a.iana-servers.net
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 9079
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;example.org.			IN	A

;; ANSWER SECTION:
example.org.		300	IN	A	96.7.129.13

;; Query time: 137 msec
;; SERVER: 199.43.135.53#53(199.43.135.53)
;; WHEN: Wed Jan 15 13:59:47 KST 2025
;; MSG SIZE  rcvd: 56

Other notes for review

I've tested dig in various environment: local, an instance in New York, and changed DNS server for few times. All cases returned 96.7.129.13.

Acknowledgements

@syjn99 syjn99 requested a review from a team as a code owner January 15, 2025 05:16
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@nisdas nisdas enabled auto-merge January 15, 2025 06:03
@nisdas nisdas added this pull request to the merge queue Jan 15, 2025
Merged via the queue into prysmaticlabs:develop with commit 34ff4c3 Jan 15, 2025
15 checks passed
@syjn99
Copy link
Contributor Author

syjn99 commented Jan 15, 2025

Hey @nisdas, I'm not sure what's happening, but IP changed again. You can find in this link. Any idea why those popular domains keep changing?

Besides, I also noticed the IP of example.com also changed just a few minutes ago.

@nisdas
Copy link
Member

nisdas commented Jan 15, 2025

It does appear it changed again @syjn99

Name:	example.org
Address: 23.215.0.132
Name:	example.org
Address: 96.7.128.192
Name:	example.org
Address: 96.7.128.186
Name:	example.org
Address: 23.215.0.133
Name:	example.org
Address: 2600:1408:ec00:36::1736:7f2f
Name:	example.org
Address: 2600:1408:ec00:36::1736:7f2e
Name:	example.org
Address: 2600:1406:bc00:17::6007:810d
Name:	example.org
Address: 2600:1406:bc00:17::6007:8128

Its likely IANA doesn't intend to keep the IP static but instead would be dynamic. We can try changing this again to account for all the possible IPs. But if this changes again, we should simply remove the test

@syjn99
Copy link
Contributor Author

syjn99 commented Jan 15, 2025

@nisdas Thanks for checking. What do you mean "for all the possible IPs"? Does this test should contain a list of IPs to match?

Besides, I also think this test can be removed, as this test scope is much closer to go-libp2p level.

@nisdas
Copy link
Member

nisdas commented Jan 15, 2025

Yes for the current test, the resolved IPs should be anyone in the list.

Besides, I also think this test can be removed, as this test scope is much closer to go-libp2p level

The host name resolution is done in prysm for discovery

@nalepae
Copy link
Contributor

nalepae commented Jan 15, 2025

TestHostIsResolved seems to fail now on all new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants