-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace new exampleIP
for example.org
#14795
Replace new exampleIP
for example.org
#14795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
It does appear it changed again @syjn99
Its likely IANA doesn't intend to keep the IP static but instead would be dynamic. We can try changing this again to account for all the possible IPs. But if this changes again, we should simply remove the test |
@nisdas Thanks for checking. What do you mean "for all the possible IPs"? Does this test should contain a list of IPs to match? Besides, I also think this test can be removed, as this test scope is much closer to |
Yes for the current test, the resolved IPs should be anyone in the list.
The host name resolution is done in prysm for discovery |
|
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR makes
TestHostIsResolved
happy by replacing IP forexample.org
. I'm not sure why its IP keeps changing every year.Other notes for review
I've tested
dig
in various environment: local, an instance in New York, and changed DNS server for few times. All cases returned96.7.129.13
.Acknowledgements