Improve blobs Beacon API endpoint #14845
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Jan 30, 2025
Comment on lines
+246
to
264
| for k, v := range m { | ||
| if v { | ||
| if k >= len(commitments) { | ||
| return nil, &core.RpcError{ | ||
| Err: fmt.Errorf("blob index %d is more than blob kzg commitment count %d for block %#x", k, len(commitments), root), | ||
| Reason: core.Internal, | ||
| } | ||
| } | ||
| if !indicesRequested { | ||
| indices = append(indices, uint64(k)) | ||
| } | ||
| } else if indicesRequested { | ||
| for _, ix := range indices { | ||
| if uint64(k) == ix { | ||
| return nil, &core.RpcError{Err: fmt.Errorf("no blob at index %d found for block %#x", k, root), Reason: core.NotFound} | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggestions for making this more straightforward/readable welcome
rkapka
commented
Jan 30, 2025
| blobs := make([]*blocks.VerifiedROBlob, len(indices)) | ||
| for i, index := range indices { | ||
| vblob, err := p.BlobStorage.Get(bytesutil.ToBytes32(root), index) | ||
| if err != nil { | ||
| log.WithFields(log.Fields{ |
There was a problem hiding this comment.
I removed this log and one more log because I don't see the point of logging out one specific thing from the whole function. As a matter of fact, I don't think we log out anything else from the whole Beacon API (note that this file is in beacon-chain/rpc, so it's limited to APIs). In my opinion if we find such logs useful, we should write a middleware that will log out every error from httputil.HandleError (most likely on the Debug level)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
500 InternalServerErrorwhen a blob for a requested index is not found. It would be more useful to return a 404 instead, letting the user know that we don't have the blob, not that something went wrong when trying to fetch it.Acknowledgements