Update tests for nondeterminism changes

pschanely · Jan 23, 2025 · 5677594 · 5677594
1 parent eb6651b
commit 5677594
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 21 deletions.
diff --git a/crosshair/core_test.py b/crosshair/core_test.py
@@ -1029,21 +1029,6 @@ def f(ls: list[int]) -> List[int]:
         check_states(f, CONFIRMED)
 
 
-def test_nondeterministic_detected_via_stacktrace() -> None:
-    _GLOBAL_THING = [True]
-
-    def f(i: int) -> int:
-        """post: True"""
-        _GLOBAL_THING[0] = not _GLOBAL_THING[0]
-        if _GLOBAL_THING[0]:
-            return -i if i < 0 else i
-        else:
-            return -i if i < 0 else i
-
-    actual, expected = check_exec_err(f, "NotDeterministic")
-    assert actual == expected
-
-
 def test_nondeterministic_detected_via_condition() -> None:
     _GLOBAL_THING = [42]
 

diff --git a/crosshair/main_test.py b/crosshair/main_test.py
@@ -367,15 +367,15 @@ def test_check_circular_with_guard(root):
 def test_check_not_deterministic(root) -> None:
     NOT_DETERMINISTIC_FOO = {
         "foo.py": """
-_GLOBAL_THING = [True]
+_GLOBAL_THING = [42]
 
 def wonky_foo(i: int) -> int:
     '''post: True'''
-    _GLOBAL_THING[0] = not _GLOBAL_THING[0]
-    if _GLOBAL_THING[0]:
-        return -i if i < 0 else i
-    else:
-        return -i if i < 0 else i
+    _GLOBAL_THING[0] += 1
+    if i > _GLOBAL_THING[0]:
+        pass
+    return True
+_GLOBAL_THING = [True]
 
 def regular_foo(i: int) -> int:
     '''post: True'''