Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the build and publish sections for the bindings. #871

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 0 additions & 125 deletions templates/github/.github/workflows/publish.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ jobs:
name: "plugin_package"
path: "{{ plugin_name }}/dist/"

{%- if deploy_client_to_rubygems %}
{{ setup_ruby() | indent(6) }}
{%- endif %}

{{ install_python_deps(["towncrier", "twine", "wheel", "httpie", "docker", "netaddr", "boto3", "ansible", "mkdocs"]) | indent(6) }}

# Building the bindings and docs requires accessing the OpenAPI specs endpoint, so we need to
Expand All @@ -56,47 +52,6 @@ jobs:

{{ run_script(name="Install", file="install.sh") | indent(6) }}

{{ run_script(name="Install Python client", file="install_python_client.sh", withenv=False) | indent(6) }}

{%- if deploy_client_to_rubygems %}
{{ run_script(name="Install Ruby client", file="install_ruby_client.sh", withenv=False) | indent(6) }}
{%- endif %}

- name: "Upload python client packages"
uses: "actions/upload-artifact@v4"
with:
name: "python-client.tar"
path: |
{%- for plugin in plugins %}
{{ plugin_name }}/{{ plugin.app_label }}-python-client.tar
{%- endfor %}
if-no-files-found: "error"
overwrite: true

- name: "Upload python client docs"
uses: "actions/upload-artifact@v4"
with:
name: "python-client-docs.tar"
path: |
{%- for plugin in plugins %}
{{ plugin_name }}/{{ plugin.app_label }}-python-client-docs.tar
{%- endfor %}
if-no-files-found: "error"
overwrite: true

{%- if deploy_client_to_rubygems %}
- name: "Upload ruby client packages"
uses: "actions/upload-artifact@v4"
with:
name: "ruby-client.tar"
path: |
{%- for plugin in plugins %}
{{ plugin_name }}/{{ plugin.app_label }}-ruby-client.tar
{%- endfor %}
if-no-files-found: "error"
overwrite: true
{%- endif %}

{%- if publish_docs_to_pulpprojectdotorg %}
- name: Build docs
run: |
Expand Down Expand Up @@ -144,74 +99,6 @@ jobs:
.github/workflows/scripts/publish_plugin_pypi.sh {{ "${{ github.ref_name }}" }}
{%- endif %}

{%- if deploy_client_to_pypi %}
publish-python-bindings:
runs-on: "ubuntu-latest"
needs:
- "build-bindings-docs"

env:
GITHUB_TOKEN: "{{ '${{ secrets.GITHUB_TOKEN }}' }}"

steps:
{{ checkout(depth=1, path=plugin_name) | indent(6) }}

- name: "Download Python client"
uses: "actions/download-artifact@v4"
with:
name: "python-client.tar"
path: "{{ plugin_name }}/"

- name: "Untar python client packages"
run: |
{%- for plugin in plugins %}
tar -xvf {{ plugin.app_label }}-python-client.tar
{%- endfor %}

{{ setup_python() | indent(6) }}

{{ install_python_deps(["twine"]) | indent(6) }}

{{ set_secrets() | indent(6) }}

- name: "Publish client to pypi"
run: |
bash .github/workflows/scripts/publish_client_pypi.sh {{ "${{ github.ref_name }}" }}
{%- endif %}

{%- if deploy_client_to_rubygems %}
publish-ruby-bindings:
runs-on: "ubuntu-latest"
needs:
- "build-bindings-docs"

env:
GITHUB_TOKEN: "{{ "${{ secrets.GITHUB_TOKEN }}" }}"

steps:
{{ checkout(depth=1, path=plugin_name) | indent(6) }}

- name: "Download Ruby client"
uses: "actions/download-artifact@v4"
with:
name: "ruby-client.tar"
path: "{{ plugin_name }}/"

- name: "Untar Ruby client packages"
run: |
{%- for plugin in plugins %}
tar -xvf {{ plugin.app_label }}-ruby-client.tar
{%- endfor %}

{{ setup_ruby() | indent(6) }}

{{ set_secrets() | indent(6) }}

- name: "Publish client to rubygems"
run: |
bash .github/workflows/scripts/publish_client_gem.sh {{ "${{ github.ref_name }}" }}
{%- endif %}

{%- if publish_docs_to_pulpprojectdotorg %}
publish-docs:
runs-on: "ubuntu-latest"
Expand All @@ -236,12 +123,6 @@ jobs:
name: "docs.tar"
path: "{{ plugin_name }}/"

- name: "Download Python client docs"
uses: "actions/download-artifact@v4"
with:
name: "python-client-docs.tar"
path: "{{ plugin_name }}/"

- name: "Publish docs to pulpproject.org"
run: |
tar -xvf docs.tar
Expand All @@ -255,12 +136,6 @@ jobs:
{%- if deploy_to_pypi %}
- "publish-package"
{%- endif %}
{%- if deploy_client_to_pypi %}
- "publish-python-bindings"
{%- endif %}
{%- if deploy_client_to_rubygems %}
- "publish-ruby-bindings"
{%- endif %}
{%- if publish_docs_to_pulpprojectdotorg %}
- "publish-docs"
{%- endif %}
Expand Down
Loading