Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release process #63

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix release process #63

merged 1 commit into from
Nov 16, 2023

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Nov 16, 2023

[noissue]

@@ -1,5 +1,4 @@
[tool.towncrier]
package = "pulpcore.cli.ostree"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows running towncrier without installing the actual package as long as providing the correct version, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose yes? I am trying to perform a release and this seemed to be the only discrepancy between pulp-cli-gem (successfully released 3 weeks ago) and pulp-cli-ostree.

I am seeing some errors in the release pipeline and I thought this could resolve the issues: https://github.com/pulp/pulp-cli-ostree/actions/runs/6891454589/job/18746543474#step:6:81.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks right to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to provide the proper version anyway, because it runs just before bump2version is doing it's magic.
https://github.com/pulp/pulp-cli-ostree/blob/main/.ci/scripts/release.sh#L22

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release was successful thanks to this change.

@lubosmj lubosmj merged commit a8f7f44 into pulp:0.2 Nov 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants