drop context selectedRepo & updateTitle

pulp · Oct 24, 2024 · 4a841f8 · 4a841f8
1 parent 4b8ca33
commit 4a841f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/src/app-context.tsx b/src/app-context.tsx
@@ -12,10 +12,8 @@ export interface IAppContextType {
   featureFlags; // deprecated
   hasPermission: (name: string) => boolean;
   queueAlert: (alert: AlertType) => void;
-  selectedRepo?: string; // deprecated
   setAlerts: (alerts: AlertType[]) => void;
   settings; // deprecated
-  updateTitle: (title: string) => void; // deprecated
   user; // deprecated
 }
 
@@ -46,11 +44,6 @@ export const AppContextProvider = ({ children }: { children: ReactNode }) => {
 
   const queueAlert = (alert) => setAlerts((alerts) => [...alerts, alert]);
   const hasPermission = (_name) => true; // FIXME: permission handling
-  const updateTitle = (title) => {
-    document.title = title
-      ? `${APPLICATION_NAME} - ${title}`
-      : APPLICATION_NAME;
-  };
 
   return (
     <AppContext.Provider
@@ -61,7 +54,6 @@ export const AppContextProvider = ({ children }: { children: ReactNode }) => {
         queueAlert,
         setAlerts,
         settings,
-        updateTitle,
         // FIXME: hack
         user: credentials
           ? {

diff --git a/src/components/base-header.tsx b/src/components/base-header.tsx
@@ -1,6 +1,5 @@
 import { Title } from '@patternfly/react-core';
 import React, { type ReactNode, useEffect } from 'react';
-import { useAppContext } from 'src/app-context';
 import './header.scss';
 
 interface IProps {
@@ -28,9 +27,10 @@ export const BaseHeader = ({
   status,
   subTitle,
 }: IProps) => {
-  const { updateTitle } = useAppContext();
   useEffect(() => {
-    updateTitle(title);
+    document.title = title
+      ? `${APPLICATION_NAME} - ${title}`
+      : APPLICATION_NAME;
   }, [title]);
 
   return (