Update signing key name

[hstct]

[noissue]

[hstct]

I used this occasion to update the test data with the new signing key as well. Since it probably will cause some confusion later on if we don't :)

[hstct]

We need to backport this as well probably best to just update alle the branches with it

[mdellweg]

Are you using any of the pulpcore gpgkey related fixtures? Then both names can happen to appear depending on the installed version of pulpcore.

[quba42]

So, for example, we would need to use one for regular tests and a different one for lowerbounds?

[hstct]

More likely double check onto which branches this got backported to in pulpcore. I will do that once we are ready to merge this.

[mdellweg]

I would prefer extracting the name from the same fixture providing the key.

[quba42]

I don't think it is worth doing:

• Others don't have a better solution either, e.g.: [PR #3317/103e466f backport][3.23] Use new fixture signing keys pulp_rpm#3327
• We need to unbreak the tests ASAP.
• Hopefully, the need to swap out test signing keys is something that only happens once every couple of years.

[hstct]

@mdellweg I updated it so it shouldn't require the actual key name anymore. The keyid should be sufficient and that one I can easily get from the pulpcore fixtures. So hopefully this will work on any version.

[patchback]

Backport to 3.0: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b639880 on top of patchback/backports/3.0/b63988040b4eac0018cb917368599242507a7612/pr-956

Backporting merged PR #956 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/pulp/pulp_deb.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.0/b63988040b4eac0018cb917368599242507a7612/pr-956 upstream/3.0

4. Now, cherry-pick PR Update signing key name #956 contents into that branch:

   $ git cherry-pick -x b63988040b4eac0018cb917368599242507a7612

   If it'll yell at you with something like fatal: Commit b63988040b4eac0018cb917368599242507a7612 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x b63988040b4eac0018cb917368599242507a7612

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Update signing key name #956 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.0/b63988040b4eac0018cb917368599242507a7612/pr-956

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 3.1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.1/b63988040b4eac0018cb917368599242507a7612/pr-956

Backported as #964

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.