-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sync with tls_validation=False #656
Conversation
@@ -1,6 +1,8 @@ | |||
import logging | |||
import tempfile | |||
from typing import Optional, Any, AsyncGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turned out to become a rather hot line...
I adopted the version import typing as t
with positive experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 6644673 on top of patchback/backports/3.11/6644673ff04a3ad5775f2e4995edf18e054e0758/pr-656 Backporting merged PR #656 into main
🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #660 🤖 @patchback |
Fix sync with tls_validation=False (cherry picked from commit 6644673)
…4a3ad5775f2e4995edf18e054e0758/pr-656 [PR #656/6644673f backport][3.11] Fix sync with tls_validation=False
fixes: #653