[WIP] Alternative approach for native providers #1268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to try this for awsx to fix #1191 to see what the issues would be. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
This is #1268 without the sharding. This should be safe as it is not affecting any providers per se yet, just building up a capability. --------- Co-authored-by: Florian Stadler <[email protected]>
|
We've essentially mainlined this piecemeal with @rquitales and used to onboard AWSX, with aws-apigateway and EKS coming next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1140, on top of #1217.
Instead of forking the bridged template -- which will inevitably cause the kind of drift we want to avoid -- this adds a new parameter to the bridged template to disable bridge-specific things like
make upgrade, etc.I don't know if this is even feasible. I do like that it ships a
Makefileto the native provider. A couple targets are no-op'd, some CI workflows are omitted, and instead of invoking tfgen we invoke the provider's gen binary. This means the manual part of onboarding native providers will probably look more like getting the codegen binaries to be invoked more like tfgen.There are still references to tfgen/upstream/etc. but this is cosmetic. I think this is worth exploring more as it might make onboarding easier.