Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditional id-token permissions #1333

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ jobs:
name: publish
permissions:
contents: write
#{{- if .Config.GCP }}#
id-token: write
#{{- end }}#
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ jobs:
name: publish
permissions:
contents: write
#{{- if .Config.GCP }}#
id-token: write
#{{- end }}#
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,9 @@ jobs:
verify_release:
name: verify_release
needs: publish_sdk
#{{- if .Config.GCP }}#
permissions:
contents: write
id-token: write
#{{- end }}#
uses: ./.github/workflows/verify-release.yml
secrets: inherit
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ jobs:
permissions:
contents: write
pull-requests: write
#{{- if .Config.GCP }}#
id-token: write
#{{- end }}#
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
runner: ["ubuntu-latest"]
#{{- end }}#
runs-on: ${{ matrix.runner }}
#{{- if and .Config.ReleaseVerification .Config.GCP }}#
#{{- if .Config.ReleaseVerification }}#
permissions:
contents: 'read'
id-token: 'write'
Expand Down
1 change: 1 addition & 0 deletions provider-ci/test-providers/acme/.github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
3 changes: 3 additions & 0 deletions provider-ci/test-providers/acme/.github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ jobs:
verify_release:
name: verify_release
needs: publish_sdk
permissions:
contents: write
id-token: write
uses: ./.github/workflows/verify-release.yml
secrets: inherit
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
permissions:
contents: write
pull-requests: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
3 changes: 3 additions & 0 deletions provider-ci/test-providers/aws/.github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@ jobs:
verify_release:
name: verify_release
needs: publish_sdk
permissions:
contents: write
id-token: write
uses: ./.github/workflows/verify-release.yml
secrets: inherit
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
permissions:
contents: write
pull-requests: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ jobs:
# See the docs for a similar example to this: https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson
runner: ${{ fromJSON(format('["ubuntu-latest","windows-latest"{0}]', inputs.enableMacRunner && ',"macos-latest"' || '')) }}
runs-on: ${{ matrix.runner }}
permissions:
contents: 'read'
id-token: 'write'
steps:
- name: Configure Git to checkout files with long names
run: git config --global core.longpaths true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ jobs:
verify_release:
name: verify_release
needs: publish_sdk
permissions:
contents: write
id-token: write
uses: ./.github/workflows/verify-release.yml
secrets: inherit
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ jobs:
permissions:
contents: write
pull-requests: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ jobs:
name: verify_release
needs: publish_sdk
permissions:
contents: write
id-token: write
uses: ./.github/workflows/verify-release.yml
secrets: inherit
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
name: publish
permissions:
contents: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
3 changes: 3 additions & 0 deletions provider-ci/test-providers/eks/.github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ jobs:
verify_release:
name: verify_release
needs: publish_sdk
permissions:
contents: write
id-token: write
uses: ./.github/workflows/verify-release.yml
secrets: inherit
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ jobs:
permissions:
contents: write
pull-requests: write
id-token: write
needs:
- prerequisites
- build_provider
Expand Down
Loading