Do not pollute workdir during pulumictl auto-installation #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Jan 31, 2025
| @@ -1,5 +1,5 @@ | |||
| package pkg | |||
|
|
|||
| const ( | |||
| defaultPulumiCTLVersion = "v0.0.46" | |||
| defaultPulumiCTLVersion = "v0.0.48" | |||
There was a problem hiding this comment.
The 0.0.46 version had replaces in go.mod that caused go install to complain. The latest version has no such problem.
VenelinMartinov
approved these changes
Jan 31, 2025
ringods
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulumictl is not discovered in PATH it is auto-installed by the Makefile.
Unfortunately the previous method used a GOPATH override to guide
go installas to where install pulumictl. As a side effect of this, the auto-installation did not use the standard Go package cache and polluted the working dir with another copy of Go package cache.After this change, auto installation happens against the standard Go package cache and the result is then copied into bin.
Users should prefer to have pulumictl in the environment than relying on the auto-installation.
Tested manually on pulumi-awsx.