Add no deps provider make target #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
changed the base branch from
master
to
vvm/disable_provider_building_in_tests
|
I personally like that a lot and would use it, but adding @iwahbe as reviewer as they focused on re-designing builds recently to cross-check if this is a good idea with respect to further plans here. |
VenelinMartinov
changed the base branch from
vvm/disable_provider_building_in_tests
to
master
iwahbe
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
It's unfortunate that we don't have a great caching solution for the schema, but we don't. If this improves the dev loop, LGTM!
I'd like to make sure we have an explanation for the extra target in the makefile when we merge. I have left a suggestion for what that would be, but you are free to expand on it.
Co-authored-by: Ian Wahbe <[email protected]>
Co-authored-by: Ian Wahbe <[email protected]>
VenelinMartinov
added a commit
that referenced
this pull request
Nov 15, 2023
I missed this in #718. Necessary to avoid any conflicts with actual files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new make target for providers
provider_no_deps- this one will just run the go build command withouttfgenandinstall_plugins. This is needed sincetfgenandinstall_pluginshave no caching, so will rerun each time and I'd like to use thego buildin pulumi/pulumi-aws#2953